Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore @icon check and modify graceful failure landing page #1328

Merged
merged 1 commit into from
Feb 10, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Feb 10, 2018

  • statusCode is a string in the case of node failures... change statusCodePage code to accommodate this.
  • revert suspension again... hopefully the last time

Applies to #1323 and #37

* `statusCode` is a string in the case of *node* failures... change `statusCodePage` code to accommodate this.
* revert suspension again... hopefully the last time

Applies to OpenUserJS#1323 and OpenUserJS#37
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Feb 10, 2018
@Martii Martii merged commit a525eab into OpenUserJS:master Feb 10, 2018
@Martii Martii deleted the statusCodeCheckType branch February 10, 2018 05:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Development

Successfully merging this pull request may close these issues.

1 participant