Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the "chunked" methodology in getMeta #761

Merged
merged 1 commit into from
Oct 6, 2015
Merged

Restore the "chunked" methodology in getMeta #761

merged 1 commit into from
Oct 6, 2015

Conversation

Martii
Copy link
Member

@Martii Martii commented Oct 6, 2015

  • Rename aChunks to aBufs to match node docs and indicate that is what we are expecting
  • .concat is vague on totalLength parameter but in (simple) tests with node it is (appearing to be) String length e.g. 1 returns one character currently ... added Watchpoint here
  • Remove the debug messages for now
  • Tested on ~112.9KiB User Script... took ~10ms-11ms versus 7ms in debug mode on full Buffers conversion... slower however less memory intensive in some use cases especially with larger scripts

Applies to #678

Refs:

Restore the "chunked" methodology in getMeta
9a09467 
* Rename `aChunks` to `aBufs` to match *node* docs and indicate that is what we are expecting
* `.concat` is vague on `totalLength` parameter but in tests with *node* it is `String` length e.g. `1` returns one character currently ... added Watchpoint here
* Remove the debug messages for now
* Tested on ~112.9KiB User Script... took ~10ms-11ms versus 7ms in debug mode on full Buffers conversion... slower **however** less memory intensive in some use cases especially with larger scripts

Applies to OpenUserJS#678

Refs:
* https://nodejs.org/api/buffer.html#buffer_class_method_buffer_concat_list_totallength
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Oct 6, 2015
Martii added a commit that referenced this pull request Oct 6, 2015
@Martii
Merge pull request #761 from Martii/Issue-678restoreChunkedMethodology
1cf54b5 
Restore the "chunked" methodology in `getMeta`

Auto-merge
@Martii Martii merged commit 1cf54b5 into OpenUserJS:master Oct 6, 2015
@Martii Martii deleted the Issue-678restoreChunkedMethodology branch October 6, 2015 18:50
@Martii Martii added the needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted. label Oct 6, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii