Add openssl3 support for msvc build #471
Conversation
There was a problem hiding this comment.
I'm not familiar with vcpkg or its ports, but can we avoid adding files with hard-coded library versions (e.g., OpenSSl 3.0.1) ? Building with a newer version of OpenSSL would require changes hare and then matching changes in OpenVPn core too, isn't it? That doesn't sound the right approach to me.
Can we have a common vcpkg port that could be used here as well as in the core. Or add this to openvpn-build?
|
Ideally we should not host any ports ourselves and use openssl3 port provided by vcpkg official repo, which is already long overdue. microsoft/vcpkg#20031 We could use vcpkg port from openvpn repo, but that would require dependency to openvpn when building openvpn-gui with openssl3. This should not be a problem for release building since we checkout all repos. For GitHub Actions we could have a bit ugly solution of cloning openvpn before building openvpn-gui. I think we can live with it until openssl3 is added into vcpkg. I am also thinking that we need to support building openvpn-gui with both openssl1.1.1 and openssl3. Right now we use vcpkg manifest mode (the recommended way), where we explicitly list dependencies which are automatically installed, and we list openssl3. Maybe we should drop it and use whatever openssl library is installed. |
|
Also let GitHub Actions build with both flavors - openssl1.1.1 and openssl3. |
|
Hi,
On Mon, Jan 24, 2022 at 11:33:16PM -0800, Lev Stipakov wrote:
I am also thinking that we need to support building openvpn-gui with both openssl1.1.1 and openssl3. Right now we use vcpkg manifest mode (the recommended way), where we explicitly list dependencies which are automatically installed, and we list openssl3. Maybe we should drop it and use whatever openssl library is installed.
Is *anything* "installed" on a MSVC build environment by default?
MinGW builds have no "default" OpenSSL (as it needs to be cross-built)
gert
…--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany ***@***.***
|
|
No, nothing is installed. But that's not an issue - |
|
Hi,
On Tue, Jan 25, 2022 at 12:11:03AM -0800, Lev Stipakov wrote:
No, nothing is installed. But that's not an issue - `vcpkg install openssl` and `vcpkg install openssl3` do the thing. And with caching it doesn't take time.
You write
"Maybe we should drop it and use whatever openssl library is installed."
so, if "nothing is installed", that confuses me.
gert
…--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany ***@***.***
|
|
Ah, I mean whatever is "somehow" installed before building gui - the same thing we do with openvpn, where one needs to run For gui it was different - we listed dependencies (openssl) which got automatically installed as part of gui build process. But since we need to build both flavors (with openssl and openssl3), this approach doesn't work anymore. |
|
Force-pushed a new version. |
|
Gentle ping @selvanair. Note that there are no changes (anymore) to the code. |
- remove vcpkg manifest and use whatever openssl version is installed. To build with openssl3, one could use openssl3 port from openvpn/contrib/vcpkg-ports. - build with openssl1.1.1 and openssl3 in GitHub Actions Signed-off-by: Lev Stipakov <lev@openvpn.net>
Add openssl3 support for msvc build
remove vcpkg manifest and use whatever openssl
version is installed. To build with openssl3, one could
use openssl3 port from openvpn/contrib/vcpkg-ports.
build with openssl1.1.1 and openssl3 in GitHub Actions