Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Location Context CRUD #50

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Add Location Context CRUD #50

merged 5 commits into from
Oct 15, 2024

Conversation

vladhss
Copy link
Contributor

@vladhss vladhss commented Oct 14, 2024

No description provided.

@vladhss vladhss requested a review from a team as a code owner October 14, 2024 10:18
vladhanzha added 3 commits October 14, 2024 13:23
@sahaqaa
Copy link
Contributor

sahaqaa commented Oct 15, 2024 •
edited
Loading

Checked:
1/ cloudconnexa/data_source_location_context.go

  • Сompared output from Swagger and in Terraform
    // All OK!

2/ cloudconnexa/resource_location_context.go

  • Create
  • Read
  • Update (locally, in code)
  • Update (remote, in UI, to see drift and fix it)
  • Delete
  • Import
    All good.

sahaqaa
sahaqaa approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@sahaqaa sahaqaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sahaqaa sahaqaa merged commit fb6b12f into OpenVPN:main Oct 15, 2024
2 of 4 checks passed
@vladhss vladhss deleted the feature/location-context branch October 17, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahaqaa sahaqaa sahaqaa approved these changes

@arslanbekov arslanbekov arslanbekov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladhss @sahaqaa @arslanbekov