Fix on state for robot vacuum cleaners #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donavanbecker
approved these changes
Aug 20, 2024
|
Awesome! Thanks I will merge this in to beta for testing. |
donavanbecker
merged commit 808ad73
into
OpenWonderLabs:beta-3.7.1
4 of 5 checks passed
Merged
donavanbecker
added a commit
that referenced
this pull request
Sep 11, 2024
## [3.8.0](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v3.8.0) (2024-09-11) ### What's Changed - Added specific macOS Bluetooth permission instructions to Readme [#1026](#1026), Thanks [@rSffsE](https://github.com/rSffsE) - Added partial support for `Roller Shade` deviceType. Currently only supports status. - Added `silentModeSwitch` config option for both `Curtain` & `Blind Titl` deviceTypes, allowing two switches to be display for Closing and Moding Mode. If turned on then Silent Mode is enabled. - Added option to allow invalid Characters in displayName with config `allowInvalidCharacters` - Added `dry` config option to enable Dry Status support for Water Detector - Fixed Platform BLE Scanning events not registering - Fix `On` state for robot vacuum cleaners [#1028](#1028), Thanks [@JannThomas](https://github.com/JannThomas) - Housekeeping and updated dependencies. **Full Changelog**: v3.7.0...v3.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Currently, the
onproperty of the device is used to determine whether it is running. That makes the device always active since it is always "turned on" according to the API, as long as its battery is not empty.💡 Proposed solution
We use the working statuses 'InDustCollecting' and 'Clearing' to indicate on state. Those are the statuses that are the indication That the device is actually currently cleaning.
⚙️ Release Notes
➕ Additional Information
Testing
Reviewer Nudging