Fix max retry #1088
Merged
Fix max retry #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
donavanbecker
added a commit
that referenced
this pull request
Nov 2, 2024
## [4.1.1](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v4.1.0) (2024-11-02) ### What's Changed - Remove unneeded light level check [#1096](#1096), Thanks [@dnicolson](https://github.com/dnicolson) - Remove unneeded async [#1089](#1089), [#1094](#1094), & [#1097](#1097) ; Thanks [@dnicolson](https://github.com/dnicolson) - Fix characteristic warning [#1093](#1093), Thanks [@dnicolson](https://github.com/dnicolson) - Fix light level [#1092](#1092), Thanks [@dnicolson](https://github.com/dnicolson) - Fix device types [#1091](#1091), Thanks [@dnicolson](https://github.com/dnicolson) - Fix curtain light sensor [#1090](#1090), Thanks [@dnicolson](https://github.com/dnicolson) - Fix max retry [#1088](#1088), Thanks [@dnicolson](https://github.com/dnicolson) - Housekeeping and updated dependencies. **Full Changelog**: v4.1.0...v4.1.1
Merged
donavanbecker
added a commit
that referenced
this pull request
Nov 2, 2024
## [4.1.1](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v4.1.0) (2024-11-02) ### What's Changed - Remove unneeded light level check [#1096](#1096), Thanks [@dnicolson](https://github.com/dnicolson) - Remove unneeded async [#1089](#1089), [#1094](#1094), & [#1097](#1097) ; Thanks [@dnicolson](https://github.com/dnicolson) - Fix characteristic warning [#1093](#1093), Thanks [@dnicolson](https://github.com/dnicolson) - Fix light level [#1092](#1092), Thanks [@dnicolson](https://github.com/dnicolson) - Fix device types [#1091](#1091), Thanks [@dnicolson](https://github.com/dnicolson) - Fix curtain light sensor [#1090](#1090), Thanks [@dnicolson](https://github.com/dnicolson) - Fix max retry [#1088](#1088), Thanks [@dnicolson](https://github.com/dnicolson) - Housekeeping and updated dependencies. **Full Changelog**: v4.1.0...v4.1.1
donavanbecker
added a commit
that referenced
this pull request
Nov 2, 2024
- Remove unneeded light level check [#1096](#1096), Thanks [@dnicolson](https://github.com/dnicolson) - Remove unneeded async [#1089](#1089), [#1094](#1094), & [#1097](#1097) ; Thanks [@dnicolson](https://github.com/dnicolson) - Fix characteristic warning [#1093](#1093), Thanks [@dnicolson](https://github.com/dnicolson) - Fix light level [#1092](#1092), Thanks [@dnicolson](https://github.com/dnicolson) - Fix device types [#1091](#1091), Thanks [@dnicolson](https://github.com/dnicolson) - Fix curtain light sensor [#1090](#1090), Thanks [@dnicolson](https://github.com/dnicolson) - Fix max retry [#1088](#1088), Thanks [@dnicolson](https://github.com/dnicolson) - Housekeeping and updated dependencies. **Full Changelog**: v4.1.0...v4.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
The value
0cannot be used as it is evaluated in the same way as being unset.💡 Proposed solution
Check the actual type of the value to allow 0 retries.
This is needed with v4.0.0+ as
READ_TIMEOUTerrors occur even on success, resulting in erratic retry behavior. Using v.3.7.0 is still the safest option.