Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mappingMode not being read from the config directly #667

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Fixes mappingMode not being read from the config directly #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffa6da5
fixes mappingMode variable not working
AndreasVerhoeven Jan 30, 2023
f310ba2
fixes mappingMode variable not working
AndreasVerhoeven Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/device/blindtilt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class BlindTilt {
this.setupMqtt(device);
this.context();

this.mappingMode = (device.blindTilt?.mappingMode as BlindTiltMappingMode) ?? BlindTiltMappingMode.OnlyUp;
this.mappingMode = (device.blindTilt?.mode as BlindTiltMappingMode) ?? BlindTiltMappingMode.OnlyUp;
this.debugLog(`Mapping mode: ${this.mappingMode}`);

// this is subject we use to track when we need to POST changes to the SwitchBot API
Expand Down Expand Up @@ -1312,10 +1312,10 @@ export class BlindTilt {
config['maxRetry'] = device.maxRetry;
}

if(device.blindTilt?.mappingMode === undefined) {
config['mappingMode'] = BlindTiltMappingMode.OnlyUp;
if(device.blindTilt?.mode === undefined) {
config['mode'] = BlindTiltMappingMode.OnlyUp;
} else {
config['mappingMode'] = device.blindTilt?.mappingMode;
config['mode'] = device.blindTilt?.mode;
}

if (Object.entries(config).length !== 0) {
Expand Down
2 changes: 1 addition & 1 deletion src/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export type curtain = {
};

export type blindTilt = {
mappingMode?: string;
mode?: string;
updateRate?: number;
};

Expand Down