v3.1.1 #918
Merged
v3.1.1 #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## ♻️ Current situation The retry functionality introduced in #694 has no effect. ## 💡 Proposed solution Revert the change to reduce complexity and use async/await.
Co-authored-by: Donavan Becker <beckersmarthome@icloud.com>
## ♻️ Current situation The following error appears: ``` This plugin threw an error from the characteristic 'Hold Position': Characteristic Property 'minValue' can only be set for characteristics with numeric format, but not for bool. See https://homebridge.io/w/JtMGR for more info. This plugin threw an error from the characteristic 'Hold Position': Characteristic Property 'maxValue' can only be set for characteristics with numeric format, but not for bool. See https://homebridge.io/w/JtMGR for more info. This plugin threw an error from the characteristic 'Hold Position': Characteristic Property `minStep` can only be set for characteristics with numeric format, but not for bool. See https://homebridge.io/w/JtMGR for more info. ``` ## 💡 Proposed solution Remove the `setProps` call.
## ♻️ Current situation If the curtain mode was not defined in the settings the following error would occur: ``` Curtain: Curtain failed BLEpushChanges with BLE Connection, Error Message: "The type of running mode is incorrect: object" ``` ## 💡 Proposed solution - Set position mode to strings - Remove redundant code - Set proper values for node-switchbot Co-authored-by: Donavan Becker <beckersmarthome@icloud.com>
## ♻️ Current situation The `require` function is not supported with ESM, leading the following error: ``` ReferenceError: require is not defined ``` ## 💡 Proposed solution Use a dynamic import.
## ♻️ Current situation Lint globbing doesn't work. ## 💡 Proposed solution Fix glob pattern and reuse the existing npm script.
## [3.1.1](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v3.1.1) (2024-02-05) ### What's Changed - Fix BLE connection [#907](#907), Thanks [@dnicolson](https://github.com/dnicolson) - Fix BLE curtain mode [#908](#908), Thanks [@dnicolson](https://github.com/dnicolson) - Fix curtain characteristic warning [#909](#909), Thanks [@dnicolson](https://github.com/dnicolson) - Revert curtain retry functionality [#911](#911), Thanks [@dnicolson](https://github.com/dnicolson) - Code Cleaup [#910](#910) [#912](#912) [#913](#913) [#917](#917), Thanks [@dnicolson](https://github.com/dnicolson) - Housekeeping and updated dependencies. **Full Changelog**: v3.1.0...v3.1.1
banboobee
pushed a commit
to banboobee/homebridge-switchbot
that referenced
this pull request
Mar 2, 2024
- Fix BLE connection [OpenWonderLabs#907](OpenWonderLabs#907), Thanks [@dnicolson](https://github.com/dnicolson) - Fix BLE curtain mode [OpenWonderLabs#908](OpenWonderLabs#908), Thanks [@dnicolson](https://github.com/dnicolson) - Fix curtain characteristic warning [OpenWonderLabs#909](OpenWonderLabs#909), Thanks [@dnicolson](https://github.com/dnicolson) - Revert curtain retry functionality [OpenWonderLabs#911](OpenWonderLabs#911), Thanks [@dnicolson](https://github.com/dnicolson) - Code Cleaup [OpenWonderLabs#910](OpenWonderLabs#910) [OpenWonderLabs#912](OpenWonderLabs#912) [OpenWonderLabs#913](OpenWonderLabs#913) [OpenWonderLabs#917](OpenWonderLabs#917), Thanks [@dnicolson](https://github.com/dnicolson) - Housekeeping and updated dependencies. **Full Changelog**: OpenWonderLabs/homebridge-switchbot@v3.1.0...v3.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.1.1 (2024-02-05)
What's Changed
Full Changelog: v3.1.0...v3.1.1