Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Fix command_on_template for light_dimmer #125

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

dchesterton
Copy link
Contributor

The command_on_template should return a value between 0 and 99

@robertsLando
Copy link
Member

@dchesterton Thanks! :)

@robertsLando robertsLando merged commit 8ddf729 into OpenZWave:master Sep 23, 2019
@jshridha
Copy link
Contributor

@robertsLando This actually reverts the code that was put in place by 771c68e. I agree that the brightness should return 0-99 for setting a new brightness. However, setting to 255 tells the light to turn on to the previous brightness that was set before the light was turned off. This is why 771c68e changed it from 99 to 255. I believe this commit should be reverted, but we can discuss if there's other opinions or if other lights act differently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants