Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve packages READMEs #1159

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

ericnordelo
Copy link
Member

This PR fixes a copy-paste issue in the introspection package README, also accommodates READMEs to the UI of the scarb registry (fixing links not showing), and adds some extra links.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (bf5d02c) to head (23d8714).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1159   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          57       57           
  Lines        1375     1375           
=======================================
  Hits         1222     1222           
  Misses        153      153           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5d02c...23d8714. Read the comment docs.

Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a comment

> **NOTE:** This document is better viewed at https://docs.openzeppelin.com/contracts-cairo/api/access
> **NOTE:** This document is better viewed at [https://docs.openzeppelin.com/contracts-cairo/api/access](https://docs.openzeppelin.com/contracts-cairo/api/access)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should add the version to all the URLs. If users are not using the latest version, I think it'd be nice to directly link to the specific version in the docsite

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I will update, but it will make it into the next release, since all the packages have been uploaded to the registry already.

Comment on lines +3 to +4
> **NOTE:** Documentation will soon be added to [https://docs.openzeppelin.com/contracts-cairo](https://docs.openzeppelin.com/contracts-cairo)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@immrsd immrsd self-requested a review September 25, 2024 06:18
Copy link
Collaborator

@immrsd immrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
ericnordelo and others added 2 commits September 25, 2024 13:10
Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com>
@ericnordelo ericnordelo merged commit b848b55 into OpenZeppelin:main Sep 25, 2024
8 checks passed
@ericnordelo ericnordelo deleted the feat/improve-readmes branch September 25, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants