Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC20Permit Doc #1183

Merged
merged 37 commits into from
Oct 23, 2024
Merged

ERC20Permit Doc #1183

merged 37 commits into from
Oct 23, 2024

Conversation

immrsd
Copy link
Collaborator

@immrsd immrsd commented Oct 15, 2024

Adds documentation for ERC20Permit #1103

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (7ac655c) to head (3977d41).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files          47       47           
  Lines        1197     1197           
=======================================
  Hits         1100     1100           
  Misses         97       97           
Files with missing lines Coverage Δ
packages/token/src/erc20/erc20.cairo 96.55% <ø> (ø)
packages/utils/src/cryptography/snip12.cairo 83.33% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac655c...3977d41. Read the comment docs.

@immrsd immrsd marked this pull request as ready for review October 18, 2024 10:05
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Left two small format suggestions.

docs/modules/ROOT/pages/api/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/erc20.adoc Outdated Show resolved Hide resolved
@immrsd immrsd requested a review from ericnordelo October 22, 2024 16:45
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@immrsd immrsd merged commit 9ad6d13 into OpenZeppelin:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants