enforce base package to build first #118
Conversation
|
| @@ -34,7 +34,7 @@ | |||
| "nx-build-test-skip-cache": "pnpm run build-test --skip-nx-cache", | |||
| "nx-test-skip-cache": "pnpm run test --skip-nx-cache", | |||
| "build": "nx run-many -t build --parallel=1", | |||
| "build-test": "nx run-many -t style,build,test", | |||
| "build-test": "nx run-many -t style,build,test --projects=@openzeppelin/defender-base-client,* --parallel=false", | |||
There was a problem hiding this comment.
This is the relevant change, the rest are just pre-commit format changes
There was a problem hiding this comment.
This should not be necessary since parallel=1 should still run sequentially. Is it not the case?
There was a problem hiding this comment.
Doesn't seem to work :/ it tries to run notification-channel:build before base:build.
By the docs it seems tha the way to run secuentially is by setting parallel=false
There was a problem hiding this comment.
Interesting. Sounds good. Thanks
pnpm nx-build-test-skip-cache command was failing due to parallel building, some packages depend on base to build properly, so I changed secuential builds, this is slower but seems to be necesary.
cc @tirumerla