Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simulation): update simulation models (breaking change) #632

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

shahnami
Copy link
Member

@shahnami shahnami commented Dec 4, 2024

Summary

Testing Process

Checklist

  • Add a reference to related issues in the PR description.
  • Add unit tests if applicable.

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 05101ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Dec 4, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/axios@1.7.8 network Transitive: environment, filesystem +8 2.49 MB jasonsaayman
npm/rollup@4.22.4 environment, filesystem +1 2.3 MB lukastaegert

🚮 Removed packages: npm/@openzeppelin/defender-sdk@1.15.2, npm/axios@1.7.2, npm/rollup@4.19.0

View full report↗︎

Copy link

socket-security bot commented Dec 4, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@d-carmo
Copy link

d-carmo commented Dec 10, 2024

@shahnami can you sort the breaking tests, please?

@shahnami
Copy link
Member Author

@shahnami can you sort the breaking tests, please?

@tirumerla looks like this package was introduced in another PR (the one adding EAS example I think), any idea why it's complaining here?

Copy link
Member

@MCarlomagno MCarlomagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if includes breaking changes I would do a quick post in the forum just in case

@tirumerla tirumerla merged commit 314f7d5 into main Dec 13, 2024
9 checks passed
@tirumerla tirumerla deleted the plat-5699-update-sdk-simulation-models branch December 13, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants