This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Add abi parameter to deploy
#206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@ericglau excellent addition! I think we just need to update the docs with new param as well
|
@andrew-fleming The current docs are mostly for the CLI, but this new parameter is only for the NRE's |
|
Great question. Maybe we should include it in the CLI just for consistency with documenting the param? Otherwise, I think it'll be difficult for users to know about this feature. What do you think? |
|
+1 to add it to the CLI |
|
Added the param to cli and docs. |
andrew-fleming
approved these changes
Sep 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203