This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Remove invoke command #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericnordelo
commented
Oct 6, 2022
| @@ -426,6 +406,18 @@ Retrieves the nonce for the given contract address (usually an account). | |||
| nile get-nonce <contract_address> | |||
| ``` | |||
|
|
|||
| ### `get_declaration` (NRE only) | |||
There was a problem hiding this comment.
I moved get_declaration down here because, to me, it looks more organized to have NRE-only commands after CLI ones. Let me know what you think.
There was a problem hiding this comment.
Nice! Yes, I agree it looks more organized. Perhaps, it's soon time to give NRE it's own heading and save us the trouble of adding things like (NRE only)
andrew-fleming
previously approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Looks great, @ericnordelo! I left a tiny suggestion; otherwise, I think it's good to go :)
Comment on lines
+165
to
+166
| 2. This creates or updates `localhost.accounts.json` file storing all data related to accounts management | ||
| 3. The creates or updates `localhost.deployments.txt` file storing all data related to deployments |
| @@ -426,6 +406,18 @@ Retrieves the nonce for the given contract address (usually an account). | |||
| nile get-nonce <contract_address> | |||
| ``` | |||
|
|
|||
| ### `get_declaration` (NRE only) | |||
There was a problem hiding this comment.
Nice! Yes, I agree it looks more organized. Perhaps, it's soon time to give NRE it's own heading and save us the trouble of adding things like (NRE only)
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
andrew-fleming
previously approved these changes
Oct 17, 2022
martriay
previously approved these changes
Oct 21, 2022
Co-authored-by: Martín Triay <martriay@gmail.com>
ericnordelo
dismissed stale reviews from martriay and andrew-fleming
via
d8a2d8b
martriay
approved these changes
Oct 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.