Set default max_fee in account functions #262

ericglau · 2022-10-25T14:10:13Z

Fixes #261

andrew-fleming

@ericglau good improvement! I left a small comment :)

tests/commands/test_account.py

ericnordelo

LGTM!

ericglau · 2022-11-03T15:57:31Z

Updated test_send_defaults to use mocks for asserting default values.

andrew-fleming

Looks good to go!

Set default max_fee in account functions

49d78c1

ericglau requested review from martriay, ericnordelo and andrew-fleming October 25, 2022 14:10

andrew-fleming reviewed Oct 31, 2022

View reviewed changes

tests/commands/test_account.py Outdated Show resolved Hide resolved

martriay previously approved these changes Nov 3, 2022

View reviewed changes

ericnordelo previously approved these changes Nov 3, 2022

View reviewed changes

Test with mocks for account.send

f733b43

ericglau dismissed stale reviews from ericnordelo and martriay via f733b43 November 3, 2022 15:40

ericglau added 2 commits November 3, 2022 11:42

Merge remote-tracking branch 'upstream/main' into 261

a232908

Merge with main

6668fb8

ericglau requested review from andrew-fleming, martriay and ericnordelo November 3, 2022 15:54

andrew-fleming approved these changes Nov 3, 2022

View reviewed changes

martriay approved these changes Nov 3, 2022

View reviewed changes

martriay merged commit c2152a9 into OpenZeppelin:main Nov 3, 2022

ericglau mentioned this pull request Nov 7, 2022

Remove max_fee argument from test script OpenZeppelin/openzeppelin-nile-upgrades#20

Closed

ericglau deleted the 261 branch November 7, 2022 15:17

Provide feedback