Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Refactor tests and change network in tests to localhost #270

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Refactor tests and change network in tests to localhost #270

merged 3 commits into from
Oct 31, 2022

Conversation

andrew-fleming
Copy link
Contributor

Resolves #269.

@andrew-fleming andrew-fleming marked this pull request as draft October 28, 2022 01:45
@andrew-fleming andrew-fleming marked this pull request as ready for review October 28, 2022 08:02
@andrew-fleming andrew-fleming changed the title Change network in tests to localhost Refactor tests and change network in tests to localhost Oct 28, 2022
martriay
martriay approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@martriay martriay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution

@martriay martriay requested a review from ericnordelo October 31, 2022 15:54
ericnordelo
ericnordelo approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrew-fleming andrew-fleming merged commit 7225ad7 into OpenZeppelin:main Oct 31, 2022
@andrew-fleming andrew-fleming deleted the fix-main-tests branch October 31, 2022 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericnordelo ericnordelo ericnordelo approved these changes

@martriay martriay martriay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too many requests (HTTP error 429) in tests
3 participants
@andrew-fleming @martriay @ericnordelo