Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Allow hex params in calldata for deployments through Account #318

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Allow hex params in calldata for deployments through Account #318

merged 4 commits into from
Dec 1, 2022

Conversation

ericnordelo
Copy link
Member

Fixes #317

martriay
martriay suggested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@martriay martriay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add tests for it? the ones that would have prevented us from releasing without this :)

andrew-fleming
andrew-fleming approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@martriay martriay merged commit e57aaf9 into OpenZeppelin:main Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrew-fleming andrew-fleming andrew-fleming approved these changes

@martriay martriay martriay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nile deploy command doesn't accept hex arguments in calldata
3 participants
@ericnordelo @martriay @andrew-fleming