Skip to content

Commit

Permalink
Reword
Browse files Browse the repository at this point in the history
  • Loading branch information
ernestognw committed Aug 30, 2024
1 parent 202b945 commit 3c87501
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions GUIDELINES.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,11 @@ In addition to the official Solidity Style Guide we have a number of other conve
abstract contract AccessControl is ..., {
```

* Return values should be explicitly named if there are more than one.
* Return values are generally not named, unless they are not immediately clear or there are multiple return values.

```solidity
function expiration() public view returns (uint256) { // Good
function hasRole() public view returns (bool isMember, uint32 currentDelay) { // Good
function expiration() public view returns (uint256 expiration) { // Bad
function hasRole() public view returns (bool, uint32) { // Bad
```

* Unchecked arithmetic blocks should contain comments explaining why overflow is guaranteed not to happen. If the reason is immediately apparent from the line above the unchecked block, the comment may be omitted.
Expand Down

0 comments on commit 3c87501

Please sign in to comment.