Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BigNumber support to expectEvent/inLogs #1026

Closed
nventuro opened this issue Jun 18, 2018 · 2 comments · Fixed by #1343
Closed

Add BigNumber support to expectEvent/inLogs #1026

nventuro opened this issue Jun 18, 2018 · 2 comments · Fixed by #1343
Labels
feature New contracts, functions, or helpers. tests Test suite and helpers.
Milestone
v2.0

Comments

@nventuro
Copy link
Contributor

nventuro commented Jun 18, 2018 •
edited by frangio
Loading

  • No support for BigNumbers
    The current equality test fails for BigNumber objects (which have an equal method). chai-bignumber supports these assertions with the chain number.should.be.bignumber.equal(otherNumber).
@nventuro nventuro mentioned this issue Jun 18, 2018
Merged
4 tasks
@nventuro nventuro changed the title expectEvent/inLogs doesn't work for BigNumbers expectEvent/inLogs could be improved Jun 18, 2018
@nventuro
Copy link
Contributor Author

Superceded by #1169 and #1189

@frangio frangio reopened this Aug 15, 2018
@frangio frangio added feature New contracts, functions, or helpers. tests Test suite and helpers. labels Aug 15, 2018
@frangio
Copy link
Contributor

frangio commented Aug 15, 2018

Reopening because we have no issue to track supporting BigNumber equality in expectEvent.

@frangio frangio mentioned this issue Aug 15, 2018
Merged
@nventuro nventuro changed the title expectEvent/inLogs could be improved Add BigNumber support to expectEvent/inLogs Aug 16, 2018
@nventuro nventuro mentioned this issue Aug 16, 2018
Closed
6 tasks
@nventuro nventuro added this to the v2.1 milestone Aug 16, 2018
@nventuro nventuro mentioned this issue Sep 19, 2018
Closed
jbogacz added a commit to jbogacz/openzeppelin-solidity that referenced this issue Sep 20, 2018
@jbogacz
Add BigNumber support to expectEvent/inLogs (OpenZeppelin#1026)
70d3533 
* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js
jbogacz added a commit to jbogacz/openzeppelin-solidity that referenced this issue Sep 20, 2018
@jbogacz
Add BigNumber support to expectEvent/inLogs (OpenZeppelin#1026)
b8c6785 
* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js
jbogacz added a commit to jbogacz/openzeppelin-solidity that referenced this issue Sep 20, 2018
@jbogacz
Add BigNumber support to expectEvent/inLogs (OpenZeppelin#1026)
b643d73 
* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js
jbogacz added a commit to jbogacz/openzeppelin-solidity that referenced this issue Sep 21, 2018
@jbogacz
Add BigNumber support to expectEvent/inLogs (OpenZeppelin#1026)
e4e9b63 
* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js
@jbogacz jbogacz mentioned this issue Sep 24, 2018
Merged
nventuro pushed a commit that referenced this issue Sep 26, 2018
@jbogacz @nventuro
Add BigNumber support to expectEvent/inLogs (#1026) (#1338)
947de54 
* Add BigNumber support to expectEvent/inLogs (#1026)

* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js

* Refactor expectEvent.inLogs function to use simple value number check

* Introduced should.be.bignumber method to compare BigNumber values

* Destructure transaction object to extract logs field
nventuro pushed a commit that referenced this issue Sep 27, 2018
@jbogacz @nventuro
Feature/use expect event in test logs assertions #1232 (#1343)
536262f 
* Add BigNumber support to expectEvent/inLogs (#1026)

* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js

* Refactor expectEvent.inLogs function to use simple value number check

* Introduced should.be.bignumber method to compare BigNumber values

* Use expectEvent to test logs (#1232)

* Removed trailing space
come-maiz pushed a commit that referenced this issue Oct 21, 2018
@jbogacz @come-maiz
Add BigNumber support to expectEvent/inLogs (#1026) (#1338)
a9af619 
* Add BigNumber support to expectEvent/inLogs (#1026)

* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js

* Refactor expectEvent.inLogs function to use simple value number check

* Introduced should.be.bignumber method to compare BigNumber values

* Destructure transaction object to extract logs field

(cherry picked from commit 947de54)
come-maiz pushed a commit that referenced this issue Oct 21, 2018
@jbogacz @come-maiz
Feature/use expect event in test logs assertions #1232 (#1343)
39db4b4 
* Add BigNumber support to expectEvent/inLogs (#1026)

* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js

* Refactor expectEvent.inLogs function to use simple value number check

* Introduced should.be.bignumber method to compare BigNumber values

* Use expectEvent to test logs (#1232)

* Removed trailing space

(cherry picked from commit 536262f)
@come-maiz come-maiz modified the milestones: v2.1, v2.0 Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New contracts, functions, or helpers. tests Test suite and helpers.
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Feature/use expect event in test logs assertions #1232 jbogacz/openzeppelin-solidity
3 participants
@frangio @come-maiz @nventuro