Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove selfdestruct from BreakInvariantBounty #1384

Closed
nventuro opened this issue Oct 5, 2018 · 2 comments
Closed

Remove selfdestruct from BreakInvariantBounty #1384

nventuro opened this issue Oct 5, 2018 · 2 comments
Labels
contracts Smart contract code.
Milestone
v2.0

Comments

@nventuro
Copy link
Contributor

nventuro commented Oct 5, 2018

selfdestruct can lead to tricky situations, has been the cause of major bugs, and has a debatable usefulness. We should avoid using it whenever possible.

Note that this is not a breaking change since this contract is in the drafts directory in the 2.0 release.
@nventuro nventuro added kind:improvement contracts Smart contract code. labels Oct 5, 2018
@nventuro nventuro mentioned this issue Oct 5, 2018
Closed
@Aniket-Engg
Copy link
Contributor

Do we need to remove it from BreakInvariantBounty only?

@Aniket-Engg
Copy link
Contributor

I checked that apart from BreakInvariantBounty, selfdestruct is only being used in ForceEther which is there for this destruction functionality only. So only remaining case is BreakInvariantBounty. I will submit a PR with the required changes.

Aniket-Engg added a commit to Aniket-Engg/zeppelin-solidity that referenced this issue Oct 5, 2018
@Aniket-Engg
fixes OpenZeppelin#1384
bea7f27
@Aniket-Engg Aniket-Engg mentioned this issue Oct 5, 2018
Merged
nventuro pushed a commit that referenced this issue Oct 8, 2018
@Aniket-Engg @nventuro
Removed selfdestruct from BreakInvariantBounty (#1385)
41f84f8 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* updates

* fixes #1384

* introduced claimable and cancelBounty

* cancelBounty tests

* Update BreakInvariantBounty.test.js
nventuro pushed a commit to nventuro/openzeppelin-contracts that referenced this issue Oct 18, 2018
@Aniket-Engg @nventuro
Removed selfdestruct from BreakInvariantBounty (OpenZeppelin#1385)
66bad4f 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (OpenZeppelin#1359)"

This reverts commit a688977.

* updates

* fixes OpenZeppelin#1384

* introduced claimable and cancelBounty

* cancelBounty tests

* Update BreakInvariantBounty.test.js

(cherry picked from commit 41f84f8)
@come-maiz come-maiz added this to the v2.0 milestone Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contracts Smart contract code.
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
3 participants
@come-maiz @nventuro @Aniket-Engg