Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove npm install script that copies Zeppelin contracts to contract/ folder #253

Closed
maraoz opened this issue Jun 13, 2017 · 5 comments
Closed

Remove npm install script that copies Zeppelin contracts to contract/ folder #253

maraoz opened this issue Jun 13, 2017 · 5 comments
Labels
good first issue Low hanging fruit for new contributors to get involved!

Comments

@maraoz
Copy link
Contributor

maraoz commented Jun 13, 2017

Not needed anymore, as latest truffle supports npm integration
@maraoz maraoz added chore good first issue Low hanging fruit for new contributors to get involved! labels Jun 13, 2017
@rstormsf
Copy link
Contributor

rstormsf commented Jun 20, 2017 •
edited
Loading

Looks like current package.json doesn't have any post-install. Am I right?

@maraoz
Copy link
Contributor Author

maraoz commented Jun 20, 2017

I meant "install", sorry

@maraoz maraoz changed the title Remove npm post-install script that copies Zeppelin contracts to contract/ folder Remove npm install script that copies Zeppelin contracts to contract/ folder Jun 20, 2017
@rstormsf rstormsf mentioned this issue Jun 22, 2017
Merged
@rstormsf
Copy link
Contributor

@maraoz #272 done

@rstormsf
Copy link
Contributor

@maraoz - would love if it can be updated in npmjs registry, cause it creates zeppelin folder every time we do yarn add zeppelin-solidity

@maraoz
Copy link
Contributor Author

maraoz commented Jun 28, 2017

We're planning on releasing a new minor version next week after merging some of the pending PRs :)

@rstormsf rstormsf mentioned this issue Jun 29, 2017
Closed
@SylTi SylTi mentioned this issue Jul 2, 2017
Closed
ProphetDaniel pushed a commit to classicdelta/Smart-Contracts that referenced this issue Mar 9, 2018
@rstormsf
Fixes OpenZeppelin#253
1b6e4eb
This was referenced Aug 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low hanging fruit for new contributors to get involved!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maraoz @rstormsf