Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multi send #1042

Closed

Conversation

AngelicaFulcher
Copy link

@AngelicaFulcher AngelicaFulcher commented Jun 22, 2018

Fixes #704

🚀 Description

MultiSendToken contract allows the transfer of specific amounts to multiple accounts. Implemented as an extra functionality of a StandardToken.

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

@sheluchin
Copy link

What about allowing users to multisend ETH as well as ERC20 tokens?

@SCBuergel
Copy link

@sheluchin I'd suggest using e.g. wrapped ETH to multi-send Ether.

The idea here is that you could derive some custom token from this MultiSendToken in order to have the functionality, that's something very token-specific.

@sheluchin
Copy link

I understand the idea here but still think a broader approach would be better. There's obviously a need for a reference multisend contract that people can use. I don't entirely agree that it always needs to be coupled to StandardToken, as there may be users who want to multisend many different types of existing ERC20 tokens and there's no reason code like this can't be used generically.

W-ETH would work but it's somewhat inconvenient for both the sender and the receiver.

https://github.com/Alonski/MultiSendEthereum/blob/master/contracts/MultiSend.sol may be of interest to anyone reading this PR as it handles multisending ERC20 tokens as well as ETH.

In any case, thank you @AngelicaFulcher for posting this PR in the first place.

@rstormsf
Copy link
Contributor

mutlisend eth is different than erc20 multisend.
Also, I wouldn't agree multisendToken needs to inherit from StandardToken

Check out similar Dapp:
https://rstormsf.github.io/multisender/#/

@nventuro
Copy link
Contributor

Closing due to staleness. I also agree with the statement that a more generic solution would be preferred, since these can be easily added ad-hoc by users when required.

@nventuro nventuro closed this Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Airdrop contract
5 participants