fixes gh-99 PullPaymentMock needed a payable constructor

[Qkyrie]

Added payable to the PullPaymentMock constructor, which is necessary to receive the x-amount of ether needed in the tests. This fixes the travis build.

[maraoz]

Wow, I can't believe this was it... Still don't understand why this was working for most devs locally.
THANKS A LOT @Qkyrie!!! I spent a couple of hours on this yesterday and still hadn't been able to fix travis build.

[maraoz]

BTW: If you can share some lines on how you found/debugged the problem it would be helpful :)

[Qkyrie]

basically, because the error in the test was an invalid jump, only a few possibilities arise:

• array access out of bounds
• failed sub-call (due to any reason reported by the EVM including invalid jump dest in the sub-call)
• ether sent to a library fallback function
• sending ether to a function not defined as payable

because the test already failed at

let ppce = await PullPaymentMock.new({value: AMOUNT})

it was immediately clear that it had to be a constructor without payable. This became necessary since Release 0.4.0.

The reason I probably found it faster is because I had the same issues when I was upgrading the FundRequest Token.

As a sidenote, I'll be using OpenZeppelin in FundRequest's developments, love your project and I'll be writing a blogpost about it soon. I won't refrain from helping out where possible ;)

cheers!

[maraoz]

@Qkyrie Thanks a lot! Happy to hear that