Improved ERC721 granularity #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
added
contracts
frangio
reviewed
Sep 7, 2018
| * @title ERC-721 Non-Fungible Token Standard, optional enumeration extension | ||
| * @dev See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md | ||
| */ | ||
| contract IERC721Enumerable is IERC721Basic { |
There was a problem hiding this comment.
Is it possible to make this an interface?
There was a problem hiding this comment.
Interfaces cannot inherit, sadly.
contracts/token/ERC721/ERC721.sol
Outdated
| // register the supported interfaces to conform to ERC721 via ERC165 | ||
| _registerInterface(InterfaceId_ERC721Enumerable); | ||
| _registerInterface(InterfaceId_ERC721Metadata); | ||
| contract ERC721 is ERC721Basic, ERC721Enumerable, ERC721Metadata { |
frangio
approved these changes
Sep 7, 2018
This was referenced Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERC721 is the basic contract
Enumerable and Metadata are extensions
Full has both extensions