Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roles now emit events in construction and when renouncing. #1329

Merged
merged 3 commits into from
Sep 26, 2018
Merged

Roles now emit events in construction and when renouncing. #1329

merged 3 commits into from
Sep 26, 2018

Conversation

nventuro
Copy link
Contributor

I think using the Removed event is fine for renounce, but I'm open to discussion. Also, I'm not sure if there's an easy way of testing for events in a contract creation.

@nventuro nventuro added bug contracts Smart contract code. labels Sep 17, 2018
@nventuro nventuro added this to the v2.0 milestone Sep 17, 2018
@nventuro nventuro self-assigned this Sep 17, 2018
@frangio frangio changed the base branch from master to release-v2.0.0 September 17, 2018 14:18
frangio
frangio reviewed Sep 17, 2018
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we add tests for the constructor events? We can use the hash of the creation transaction that is included in the contract instance. Not sure if there is an easier way.

@nventuro nventuro changed the base branch from release-v2.0.0 to master September 26, 2018 14:25
@frangio frangio mentioned this pull request Sep 26, 2018
Closed
frangio
frangio approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nventuro!

@frangio frangio merged commit 21198bf into OpenZeppelin:master Sep 26, 2018
@nventuro nventuro deleted the fix-roles-events branch September 26, 2018 14:40
frangio pushed a commit that referenced this pull request Sep 26, 2018
@nventuro @frangio
Roles now emit events in construction and when renouncing. (#1329)
e7c99dd 
* release candidate v2.0.0-rc.1

* fix linter error

(cherry picked from commit c12a1c6)

* Roles now emit events in construction and when renouncing.

(cherry picked from commit 21198bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees

@nventuro nventuro

Labels
bug contracts Smart contract code.
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @frangio