Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed assertions from Escrow and SplitPayment. #1349

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

nventuro
Copy link
Contributor

Removing these until we have a criteria under which to add assert clauses. This will also bump coverage since solidity-coverage doesn't yet track these properly (see sc-forks/solidity-coverage#269)

@frangio frangio added this to the v2.0 milestone Sep 26, 2018
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frangio frangio merged commit db2e1d2 into OpenZeppelin:master Sep 26, 2018
frangio pushed a commit to frangio/openzeppelin-contracts that referenced this pull request Sep 26, 2018
@nventuro nventuro deleted the no-asserts branch September 26, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants