Merged latestTime, increaseTime and duration into a single time helper. #1364
Conversation
nventuro
added
tests
nventuro
changed the title
| this.start = (await latestTime()) + duration.minutes(1); // +1 minute so it starts after contract instantiation | ||
| this.cliffDuration = duration.years(1); | ||
| this.duration = duration.years(2); | ||
| // +1 minute so it starts after contract instantiation |
There was a problem hiding this comment.
This sort of thing feels brittle. I'm not saying we change it here, but now that our eyes are on it, can we think of alternative ways to achieve the same thing?
There was a problem hiding this comment.
Also thinking about how we can make the whole time testing work on an actual node at some point... Perhaps the more robust thing would be to have a mock of a timestamp ts for which ts.greaterThan(now) is always true.
There was a problem hiding this comment.
Wouldn't the mock thing need to happen at the node, though? I'm not sure how we can get around the contract executing the TIMESTAMP instruction from the suite.
There was a problem hiding this comment.
One idea that's been going around is to have a Time base contract that all contracts inherit which can be swapped out for a mock... See #355.
(cherry picked from commit 34bc709)
Could be considered part of #1362.