Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed old, unused mocks. #1382

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Removed old, unused mocks. #1382

merged 1 commit into from
Oct 6, 2018

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Oct 4, 2018

These are leftovers from before 2.0 (e.g for HasNoEther).

@nventuro nventuro added kind:improvement tests Test suite and helpers. labels Oct 4, 2018
@nventuro nventuro self-assigned this Oct 4, 2018
come-maiz
come-maiz approved these changes Oct 6, 2018
View reviewed changes
Copy link
Contributor

@come-maiz come-maiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tests pass, so these are indeed unused. Thank you!

@come-maiz come-maiz merged commit b17de01 into OpenZeppelin:master Oct 6, 2018
@nventuro nventuro deleted the old-mocks branch October 7, 2018 05:16
nventuro added a commit to nventuro/openzeppelin-contracts that referenced this pull request Oct 18, 2018
@nventuro
Removed old, unused mocks. (OpenZeppelin#1382)
41e74dd 
(cherry picked from commit b17de01)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-maiz come-maiz come-maiz approved these changes

Assignees

@nventuro nventuro

Labels
tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @come-maiz