Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a test helper with common constants #1400

Merged
merged 21 commits into from
Oct 9, 2018

Conversation

Aniket-Engg
Copy link
Contributor

Fixes #1206

nventuro
nventuro previously approved these changes Oct 9, 2018
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the best thing ever, thanks so much @Aniket-Engg!

@nventuro nventuro merged commit 58a4244 into OpenZeppelin:master Oct 9, 2018
@Aniket-Engg Aniket-Engg deleted the fix/#1206 branch October 10, 2018 05:57
nventuro pushed a commit to nventuro/openzeppelin-contracts that referenced this pull request Oct 18, 2018
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (OpenZeppelin#1359)"

This reverts commit a688977.

* updates

* fixes OpenZeppelin#1206

(cherry picked from commit 58a4244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants