Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-constructor initialization removed #1403

Merged
merged 21 commits into from
Oct 10, 2018
Merged

Non-constructor initialization removed #1403

merged 21 commits into from
Oct 10, 2018

Conversation

Aniket-Engg
Copy link
Contributor

Fixes #1391

Aniket-Engg and others added 21 commits March 11, 2018 02:50
@Aniket-Engg
signing prefix added
f2e5ed1
@Aniket-Engg
Merge branch 'master' into master
ebdae17
@Aniket-Engg
Minor improvement
2bf341c
@Aniket-Engg
Merge branch 'master' of https://github.com/Aniket-Engg/zeppelin-soli…
27c614a 
…dity
@Aniket-Engg
Tests changed
bc7ea7a
@Aniket-Engg
Successfully tested
5a72021
@Aniket-Engg
Minor improvements
de0d2d4
@Aniket-Engg
Minor improvements
7f32e5c
@Aniket-Engg
minor changes
c3fb8a8
@Aniket-Engg
Revert "Dangling commas are now required. (OpenZeppelin#1359)"
68de840 
This reverts commit a688977.
@Aniket-Engg
Merge remote-tracking branch 'upstream/master'
92b725f
@Aniket-Engg
Merge remote-tracking branch 'upstream/master'
1fe2cdf
@Aniket-Engg
updates
75bc310
@Aniket-Engg
Merge remote-tracking branch 'upstream/master'
9d9a5a0
@Aniket-Engg
Merge remote-tracking branch 'upstream/master'
10b1898
@Aniket-Engg
Merge remote-tracking branch 'upstream/master'
3858a0c
@Aniket-Engg
Merge remote-tracking branch 'upstream/master'
9484daa
@Aniket-Engg
Merge remote-tracking branch 'upstream/master'
5139019
@Aniket-Engg
Merge remote-tracking branch 'upstream/master'
3097a48
@Aniket-Engg
Merge remote-tracking branch 'upstream/master'
a46e176
@Aniket-Engg
fixes OpenZeppelin#1391
1d86e28
@Aniket-Engg
Copy link
Contributor Author

Aniket-Engg commented Oct 10, 2018 •
edited
Loading

I have gone through each contract file to ensure this. In case, any file is missing to update, let me know.

nventuro
nventuro approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always @Aniket-Engg, thanks!

@nventuro nventuro merged commit da67e43 into OpenZeppelin:master Oct 10, 2018
@Aniket-Engg Aniket-Engg deleted the fix/#1391 branch October 10, 2018 12:34
@Aniket-Engg
Copy link
Contributor Author

😊

come-maiz pushed a commit that referenced this pull request Oct 21, 2018
@Aniket-Engg @come-maiz
Non-constructor initialization removed (#1403)
3266de1 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* updates

* fixes #1391

(cherry picked from commit da67e43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aniket-Engg @nventuro