Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated functions and contracts #2125

Merged
merged 8 commits into from
Mar 16, 2020
Merged

Remove deprecated functions and contracts #2125

merged 8 commits into from
Mar 16, 2020

Conversation

nventuro
Copy link
Contributor

Part of #2086

Best reviewed commit by commit.

This PR changes the following:

  • removes ERC721.burn(owner, tokenId): use ERC721.burn(tokenId) instead
  • makes ERC721._checkOnERC721Received private: it never should've been on the API
  • removes withdrawWithGas from Escrow and PullPayment, their respective withdraw functions were replaced with the contents from withdrawWithGas

@nventuro nventuro requested a review from frangio March 13, 2020 21:01
frangio
frangio previously approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contracts/payment/PullPayment.sol Show resolved Hide resolved
@nventuro nventuro merged commit f1db309 into OpenZeppelin:master Mar 16, 2020
@nventuro nventuro deleted the remove-deprecations branch March 16, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @frangio