Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'external' functions #2162

Merged
merged 11 commits into from
Apr 2, 2020
Merged

Remove 'external' functions #2162

merged 11 commits into from
Apr 2, 2020

Commits on Mar 30, 2020

  1. Remove _grantRole and _revokeRole, replace with _setupRole

    @nventuro
    nventuro committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    9b6d893 View commit details
    Browse the repository at this point in the history

  2. Make all external AccessControl functions public

    @nventuro
    nventuro committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    dcdae3e View commit details
    Browse the repository at this point in the history

  3. Remove Ownable._transferOwnership

    @nventuro
    nventuro committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    399d2b0 View commit details
    Browse the repository at this point in the history

  4. Rename ERC721's _safeTransferFrom and _transferFrom to _safeTransfer … 

    …and _transfer
    @nventuro
    nventuro committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    376c36f View commit details
    Browse the repository at this point in the history

  5. Make all ERC721 external functions public

    @nventuro
    nventuro committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    bf8993a View commit details
    Browse the repository at this point in the history

  6. Make all miscelaneous external functions public instead

    @nventuro
    nventuro committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    71a75c6 View commit details
    Browse the repository at this point in the history

  7. Add changelog entry

    @nventuro
    nventuro committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    2a1a2b7 View commit details
    Browse the repository at this point in the history

  8. Move calldata arguments to memory

    @nventuro
    nventuro committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    c4024f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Update contracts/access/AccessControl.sol 

    Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>
    @nventuro @frangio
    nventuro and frangio authored Apr 1, 2020
    Configuration menu
    Copy the full SHA
    16e5581 View commit details
    Browse the repository at this point in the history

  2. Restrict setupRole to the constructor

    @nventuro
    nventuro committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    972a75e View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Replace isConstructor for !isContract

    @nventuro
    nventuro committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    f8104fd View commit details
    Browse the repository at this point in the history