Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add wrapper function for low level calls #2264

Merged
merged 16 commits into from
Jun 11, 2020
Merged

feat: add wrapper function for low level calls #2264

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ddb602f
feat: add wrapper function for low level calls
julianmrodri Jun 4, 2020
dde2161
add error message parameter
julianmrodri Jun 8, 2020
5fa6238
adding unit tests and required mocks
julianmrodri Jun 8, 2020
54784ff
implement error message on SafeERC20
julianmrodri Jun 8, 2020
0a0ad5e
fixed variable name in tests
julianmrodri Jun 8, 2020
6f49496
Add missing tests
nventuro Jun 10, 2020
ae8484c
Improve docs.
nventuro Jun 10, 2020
9154a5f
Add functionCallWithValue
nventuro Jun 10, 2020
65701ae
Add functionCallWithValue
nventuro Jun 10, 2020
cb390e8
Skip balance check on non-value functionCall variants
nventuro Jun 11, 2020
008a962
Increase out of gas test timeout
nventuro Jun 11, 2020
d2c376f
Fix compile errors
nventuro Jun 11, 2020
e303cce
Apply suggestions from code review
nventuro Jun 11, 2020
f10c9af
Add missing tests
nventuro Jun 11, 2020
4cc61ab
Add changelog entry
nventuro Jun 11, 2020
98a99f3
Merge branch 'master' into feature/call-wrapper-function-#2260
nventuro Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/utils/Address.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,13 @@ describe('Address', function () {
inputs: [],
}, []);

const tracker = await balance.tracker(this.contractRecipient.address);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍


await send.ether(other, this.mock.address, amount);
const receipt = await this.mock.functionCallWithValue(this.contractRecipient.address, abiEncodedCall, amount);

expect(await tracker.delta()).to.be.bignumber.equal(amount);

expectEvent(receipt, 'CallReturnValue', { data: '0x1234' });
await expectEvent.inTransaction(receipt.tx, CallReceiverMock, 'MockFunctionCalled');
});
Expand All @@ -247,11 +251,15 @@ describe('Address', function () {
inputs: [],
}, []);

const tracker = await balance.tracker(this.contractRecipient.address);

expect(await balance.current(this.mock.address)).to.be.bignumber.equal('0');
const receipt = await this.mock.functionCallWithValue(
this.contractRecipient.address, abiEncodedCall, amount, { from: other, value: amount }
);

expect(await tracker.delta()).to.be.bignumber.equal(amount);

expectEvent(receipt, 'CallReturnValue', { data: '0x1234' });
await expectEvent.inTransaction(receipt.tx, CallReceiverMock, 'MockFunctionCalled');
});
Expand Down