-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix function state mutability warning #2327
Fix function state mutability warning #2327
Conversation
Changes state mutability of granularity function from view to pure.
9620f6b
to
4b25047
Compare
This gives error in As seen the linter test is failing, looks like it also needs to be upgraded. I'll take a look if I can do that. Edit: I tried upgrading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @zemse! Thank you.
I'm about to publish a version of solhint with support for 0.7. Should I test it in the |
@fvictorio Yes, please! Let me know how it goes. |
@frangio Just published solhint@3.2.0, that works fine in that branch (there's a bazillion warnings though). I tried to make a PR upgrading it but |
@fvictorio Thanks! Seems to work well. Just updated our 0.7 branch. |
PR #1739 hardcodes ERC777 granularity to 1, this causes the
solc
compiler generates the following warning:This PR fixes the above warning by changing the state mutability of granularity function from
view
topure
.