-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SafeMath to avoid memory leaks #2462
Conversation
FIxes OpenZeppelin#2413, remove the string allocation in SafeMath default functions: caused unrecovered memory allocation even for successfull calls
After discussing offline we agreed on the following:
(This also implies that the new |
677b7a2
to
b75705e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to add the same deprecation notice for EnumerableMap.get
. We use it in ERC721.ownerOf
so while we're at it we should probably change that too.
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work thanks!
FIxes #2413, remove the string allocation in SafeMath default functions: caused unrecovered memory allocation even for successfull calls