-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize implementation of ERC20Capped #2524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Feb 17, 2021
…as for regular transfers
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Amxx
force-pushed
the
refactor/erc20cappedmint
branch
from
February 22, 2021 23:28
9256854
to
646b976
Compare
frangio
reviewed
Feb 24, 2021
* Requirements: | ||
* | ||
* - minted tokens must not cause the total supply to go over the cap. | ||
* @dev See {ERC20-_mint}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited the documentation to use this "See" format we've been useing so far.
frangio
changed the title
overload _mint in erc20capped instead of hooking to transfer
Optimize implementation of ERC20Capped
Feb 24, 2021
frangio
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
frangio
pushed a commit
that referenced
this pull request
Mar 1, 2021
(cherry picked from commit 36b8559)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2523
PR Checklist