Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mint ERC777 without reception ack #2552

Merged
merged 7 commits into from
Mar 8, 2021
Merged

Mint ERC777 without reception ack #2552

merged 7 commits into from
Mar 8, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 3, 2021 •
edited
Loading

Fixes #2271

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@frangio
Copy link
Contributor

frangio commented Mar 3, 2021

Can you add a test for the new function?

@Amxx
Copy link
Collaborator Author

Amxx commented Mar 4, 2021

Can you add a test for the new function?

done

frangio
frangio approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frangio frangio enabled auto-merge (squash) March 8, 2021 19:44
@frangio frangio merged commit 78a9821 into OpenZeppelin:master Mar 8, 2021
@Amxx Amxx deleted the feature/ERC777mintRequireAck branch March 8, 2021 22:22
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requireReceptionAck parameter is required when _mint for ERC20 compatible
2 participants
@Amxx @frangio