Add ERC165 interface detection to AccessControl #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
added a commit
that referenced
this pull request
Mar 4, 2021
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com> (cherry picked from commit 29ffe6f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been pointed out that it can be useful for platforms like OpenZeppelin Defender to be able to detect if a contract supports
AccessControl, so this adds ERC165 interface detection.I didn't think this needed documentation.
Gas
With optimizations enabled, this increased deployment cost of
AccessControlandAccessControlEnumerableby 35k and 40k gas respectively.PR Checklist