Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governor #2672

Merged
merged 202 commits into from
Jul 16, 2021
Merged

Governor #2672

merged 202 commits into from
Jul 16, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented May 14, 2021

Adding code for a modular governance system

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx
Copy link
Collaborator Author

Amxx commented Jul 9, 2021

Following you comment I did change the compatibility layer's propose function to use a strict inequality

        require(
            getVotes(msg.sender, block.number - 1) > proposalThreshold(),
            "GovernorCompatibilityBravo: proposer votes below proposal threshold"
        );

I really don't like the new behavior, because even which a proposalThreshold() being 0, proposer still need to have some voting power, and for that they need to delegate votes. I personally believe that non-strict comparison would be better here!

@frangio
Copy link
Contributor

frangio commented Jul 9, 2021

The point about the threshold being 0 is a good one. I'm ok with using >= I don't think this impacts compatibility in any meaningful way.

@frangio frangio merged commit 6c1a634 into OpenZeppelin:master Jul 16, 2021
@Amxx Amxx deleted the feature/governance branch July 16, 2021 15:47
@Amxx Amxx mentioned this pull request Aug 5, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants