Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove presets #3637

Merged
merged 10 commits into from
Nov 25, 2022
Merged

Remove presets #3637

merged 10 commits into from
Nov 25, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Aug 19, 2022 •
edited by JulissaDantes
Loading

Replaces #3470

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@BlackdoggInsane5150

This comment was marked as spam.

Sign in to view
@frangio
Copy link
Contributor

frangio commented Sep 15, 2022

We need to remove presets from the documentation guides like docs/modules/ROOT/pages/erc20.adoc.

@JulissaDantes JulissaDantes marked this pull request as ready for review November 22, 2022 18:22
@JulissaDantes JulissaDantes changed the title [next-v5.0] Remove presets Remove presets Nov 22, 2022
frangio
frangio reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a remaining preset for ERC721.

CHANGELOG.md Outdated Show resolved Hide resolved
JulissaDantes and others added 2 commits November 25, 2022 09:51
@JulissaDantes @frangio
Update CHANGELOG.md
9c3bd62 
Co-authored-by: Francisco <frangio.1@gmail.com>
@JulissaDantes
Remove preset
98a259b
@JulissaDantes
Copy link
Contributor

There seems to be a remaining preset for ERC721.

Ready!

@frangio frangio merged commit 4a9db80 into OpenZeppelin:next-v5.0 Nov 25, 2022
@BlackdoggInsane5150
Copy link

BlackdoggInsane5150 commented Dec 11, 2022 via email

@ernestognw ernestognw mentioned this pull request Jan 27, 2023
Open
@Amxx Amxx deleted the remove/presets branch April 3, 2024 23:21
This was referenced Jun 15, 2024
Open
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
This was referenced Jul 9, 2024
Open
Open
This was referenced Sep 10, 2024
Merged
Merged
This was referenced Sep 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@RomulousApollo RomulousApollo mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 12, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 8, 2024
Open
Open
This was referenced Nov 9, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Amxx @BlackdoggInsane5150 @frangio @JulissaDantes