Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Slither to 0.9.1 #3949

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Pin Slither to 0.9.1 #3949

merged 1 commit into from
Jan 12, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Jan 11, 2023

Slither 0.9.2 was just released and it includes changes to the reentrancy detector. Unfortunately this is resulting in false positives for TimelockController. This PR pins Slither to 0.9.1 until it's fixed.

Reentrancy in TimelockController.executeBatch(address[],uint256[],bytes[],bytes32,bytes32) (contracts/governance/TimelockController.sol#308-329):
	External calls:
	- _execute(target,value,payload) (contracts/governance/TimelockController.sol#325)
		- (success) = target.call{value: value}(data) (contracts/governance/TimelockController.sol#335)
	State variables written after the call(s):
	- _afterCall(id) (contracts/governance/TimelockController.sol#328)
		- _timestamps[id] = _DONE_TIMESTAMP (contracts/governance/TimelockController.sol#352)
	TimelockController._timestamps (contracts/governance/TimelockController.sol#32) can be used in cross function reentrancies:
	- TimelockController._afterCall(bytes32) (contracts/governance/TimelockController.sol#350-353)
	- TimelockController._schedule(bytes32,uint256) (contracts/governance/TimelockController.sol#252-256)
	- TimelockController.cancel(bytes32) (contracts/governance/TimelockController.sol#265-270)
	- TimelockController.getTimestamp(bytes32) (contracts/governance/TimelockController.sol#159-161)

The cross function reentrancies are all guarded and would revert on reentrancy.

@Amxx Amxx merged commit 86de1e8 into OpenZeppelin:master Jan 12, 2023
@frangio frangio deleted the pin-slither branch January 12, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants