Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TransparentUpgradeableProxy's transparency #4154

Merged
merged 22 commits into from
Apr 5, 2023
Merged

Fix TransparentUpgradeableProxy's transparency #4154

merged 22 commits into from
Apr 5, 2023
+132 −59

Commits on Mar 23, 2023

  1. manualy root ifAdmin function in TransparentUpgradeableProxy

    @Amxx
    Amxx committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    079f54e View commit details
    Browse the repository at this point in the history

  2. minor improvement

    @Amxx
    Amxx committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    48ea529 View commit details
    Browse the repository at this point in the history

  3. split fallback routing

    @Amxx
    Amxx committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    81826a5 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @Amxx
    Amxx committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    d7fbc2d View commit details
    Browse the repository at this point in the history

  5. rename _internalX → _dispatchX & returns bytes

    @Amxx
    Amxx committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a7cec2f View commit details
    Browse the repository at this point in the history

  6. view functions in the interface

    @Amxx
    Amxx committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    6d5e72f View commit details
    Browse the repository at this point in the history

  7. reorder dispatch for gas optimisation

    @Amxx
    Amxx committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    1529715 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. add changeset

    @Amxx
    Amxx committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    e8a44a7 View commit details
    Browse the repository at this point in the history

  2. typo

    @frangio
    frangio committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    5a1df2c View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. add IERC1967 & reenable ifAdmin modifier

    @Amxx
    Amxx committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f6f8a48 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/TransparentUpgradeableProxy/ifAdmin' of github.com:… 

    …Amxx/openzeppelin-contracts into fix/TransparentUpgradeableProxy/ifAdmin
    @Amxx
    Amxx committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f0ce786 View commit details
    Browse the repository at this point in the history

  3. spelling

    @Amxx
    Amxx committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    4583b59 View commit details
    Browse the repository at this point in the history

  4. Update IERC1967.sol

    @Amxx
    Amxx committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    9041109 View commit details
    Browse the repository at this point in the history

  5. re-add comment

    @Amxx
    Amxx committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    0b144e6 View commit details
    Browse the repository at this point in the history

  6. add a warning about missing ABI and possible selector clash in Transp… 

    …arentUpgradeableProxy
    @Amxx
    Amxx committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    707cde8 View commit details
    Browse the repository at this point in the history

  7. grammar

    @frangio
    frangio committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    7750b9c View commit details
    Browse the repository at this point in the history

  8. grammar

    @frangio
    frangio committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    de042ad View commit details
    Browse the repository at this point in the history

  9. fix ProxyAdmin test

    @frangio
    frangio committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5a029ce View commit details
    Browse the repository at this point in the history

  10. lint

    @frangio
    frangio committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f7595a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Merge branch 'master' into fix/TransparentUpgradeableProxy/ifAdmin

    @frangio
    frangio committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    11b4ef5 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
    @Amxx @ernestognw @frangio
    3 people committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    4b61bfe View commit details
    Browse the repository at this point in the history

  3. Update ERC1967Upgrade.sol

    @Amxx
    Amxx committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b082da8 View commit details
    Browse the repository at this point in the history