Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changesets for transparency improvements #4165

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Apr 5, 2023

Merging changesets from #3977 and #4154. The latter subsumes the former, which no longer applies in the way it was originally described (by reference to ifAdmin).

@frangio frangio requested review from Amxx and ernestognw April 5, 2023 19:12
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

⚠️ No Changeset found

Latest commit: ec0a01f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this frequently since it may break the Changesets release automation (not badly). The Changelog entries are associated with the PR that merged the change, so the Changesets PR will link this PR instead of the old one.

This is why we kept the PR links in the Changesets when we migrated and will require manual intervention on the Changesets PR.

LGTM still, this is something to care about when using the automation.

@frangio
Copy link
Contributor Author

frangio commented Apr 5, 2023

Ah interesting. I can tolerate a wrong PR link every once in a while, but we should definitely make it an infrequent occurrence.

@Amxx Amxx merged commit cf86fd9 into OpenZeppelin:master Apr 5, 2023
@frangio frangio deleted the fix-transparency-changesets branch April 5, 2023 20:36
frangio added a commit that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants