Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert memory pointer to storage pointer #4550

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Revert memory pointer to storage pointer #4550

merged 1 commit into from
Aug 30, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Aug 30, 2023 •
edited
Loading

Reverts a partially incorrect merge done in #4539. Note that the change to storage pointer was introduced in #4512 for gas efficiency.

Raised by @vladyan18

@frangio frangio requested a review from Amxx August 30, 2023 19:38
@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2023

⚠️ No Changeset found

Latest commit: 9ffc4c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx enabled auto-merge (squash) August 30, 2023 19:48
@Amxx Amxx merged commit 3266bca into OpenZeppelin:master Aug 30, 2023
15 of 16 checks passed
@frangio frangio deleted the storage-memory branch August 30, 2023 20:06
ernestognw pushed a commit that referenced this pull request Sep 8, 2023
@frangio @ernestognw
Revert memory pointer to storage pointer (#4550)
2160124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amxx Amxx Amxx approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frangio @Amxx