-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ERC1967Utils pragma to 0.8.21 and set Slither CI version to 0.10.1 #5005
Bump ERC1967Utils pragma to 0.8.21 and set Slither CI version to 0.10.1 #5005
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dimitriospapathanasiou
We don't need a changeset for that.
We need @ernestognw 's 2nd approval and we are good.
Looks good to me as well, I just added a note to the changelog referring to the breaking changes arising from this. |
CI is broken due to Slither 0.10.2. The rule breaking is pragma but I'm struggling to see why it's failing now. Let's not unblock this and set the Slither version to 0.10.1 for now. |
Fixes #4995
I noticed the related issue about the pragma that is used. After minor local tests, I verified that the increase to 0.8.21 works well.
Same as #4999 but with the proper files added. Excuse my previous PR, I am a first time contributor. Sorry for any inconvenience.
PR Checklist
npx changeset add
)