Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add P256 edge cases notes #5218

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add P256 edge cases notes #5218

wants to merge 12 commits into from
+53 −4

Commits on Sep 20, 2024

  1. Add notes

    @cairoeth
    cairoeth committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0a4b60b View commit details
    Browse the repository at this point in the history

  2. Update P256.sol

    @cairoeth
    cairoeth committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6ca7ec6 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Clarify _jAdd comment

    @cairoeth
    cairoeth committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8c4cddd View commit details
    Browse the repository at this point in the history

  2. Update comments 

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    @cairoeth @Amxx
    cairoeth and Amxx committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    32c1bad View commit details
    Browse the repository at this point in the history

  3. Add comment to _jMultShamir

    @cairoeth
    cairoeth committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    79fb345 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. add comment about unsupported private keys in the P256 fuzzing tests

    @Amxx
    Amxx committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    cc6ccb5 View commit details
    Browse the repository at this point in the history

  2. add test case with cunsupported private keys in the P256 unit tests

    @Amxx
    Amxx committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c12fbbd View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @cairoeth
    cairoeth committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0f2629a View commit details
    Browse the repository at this point in the history

  4. fix fuzzing

    @Amxx
    Amxx committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c76bcbe View commit details
    Browse the repository at this point in the history

  5. Merge branch 'p256-add-mul-comments' of https://github.com/cairoeth/o… 

    …penzeppelin-contracts into p256-add-mul-comments
    @Amxx
    Amxx committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0854a78 View commit details
    Browse the repository at this point in the history

  6. consistency

    @Amxx
    Amxx committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4a37904 View commit details
    Browse the repository at this point in the history

  7. Update test/utils/cryptography/P256.t.sol

    @Amxx
    Amxx committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    89628b0 View commit details
    Browse the repository at this point in the history