Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment and tests for zero address behavior in Ownable2Step.transferOwnership() #5226

Merged

Conversation

PurrProof
Copy link
Contributor

Fixes #5224

This pull request updates the Ownable2Step's contract transferOwnership method comments to clarify that using the zero address cancels a pending ownership transfer. Additionally, a new test case has been added to verify this behavior.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: e79fbe4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx added ignore-changeset documentation Inline comments, guides, and examples. tests Test suite and helpers. labels Sep 25, 2024
@ernestognw ernestognw merged commit cc67e0e into OpenZeppelin:master Sep 25, 2024
21 checks passed
Copy link

gitpoap-bot bot commented Sep 25, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 OpenZeppelin Contracts Contributor:

GitPOAP: 2024 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@PurrProof PurrProof deleted the test/ownable2step-cancel-transfership branch September 25, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Inline comments, guides, and examples. ignore-changeset tests Test suite and helpers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zero address check in Ownable2Step’s transferOwnership function
3 participants