Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve promise rejections handling in hardhat/async-test-sanity.js #5429

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

ursulabauer
Copy link
Contributor

I've fixed the issue with unhandled promise rejections by ensuring proper error handling.
The updated code now preserves error context, making debugging easier and improving overall reliability.

I've also added comments to clarify the changes.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Jan 12, 2025

⚠️ No Changeset found

Latest commit: 2566b5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx changed the title fix: Fix unhandled promise rejections and improve error context Updat… Improve promise rejections handling in hardhat/async-test-sanity.js Feb 3, 2025
@Amxx Amxx requested review from arr00 and ernestognw February 3, 2025 10:20
@Amxx Amxx merged commit b9dbfa7 into OpenZeppelin:master Feb 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants