Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing apostrophe owner s to owner's #5462

Merged
merged 10 commits into from
Jan 28, 2025
Merged

Add missing apostrophe owner s to owner's #5462

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
554668b
Update IERC20Permit.sol
XxAlex74xX Jan 26, 2025
2be4246
Update draft-ERC20TemporaryApproval.sol
XxAlex74xX Jan 26, 2025
9fdb4fc
Update ERC20.sol
XxAlex74xX Jan 26, 2025
a031bdc
Update ERC20.sol
XxAlex74xX Jan 27, 2025
dfdd37c
Update ERC20.sol
XxAlex74xX Jan 27, 2025
b3e087d
Update IERC20Permit.sol
XxAlex74xX Jan 27, 2025
29d89da
Update draft-ERC20TemporaryApproval.sol
XxAlex74xX Jan 27, 2025
5485b1c
Update ERC20.sol
XxAlex74xX Jan 27, 2025
f10687f
Update IERC20Permit.sol
XxAlex74xX Jan 27, 2025
9b55fd2
Apply suggestions from code review
arr00 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/token/ERC20/ERC20.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ abstract contract ERC20 is Context, IERC20, IERC20Metadata, IERC20Errors {
}

/**
* @dev Sets `value` as the allowance of `spender` over the `owner` s tokens.
* @dev Sets `value` as the allowance of `spender` over the `owner`'s tokens.
*
* This internal function is equivalent to `approve`, and can be used to
* e.g. set automatic allowances for certain subsystems, etc.
Expand Down Expand Up @@ -291,7 +291,7 @@ abstract contract ERC20 is Context, IERC20, IERC20Metadata, IERC20Errors {
}

/**
* @dev Updates `owner` s allowance for `spender` based on spent `value`.
* @dev Updates `owner`s allowance for `spender` based on spent `value`.
arr00 marked this conversation as resolved.
Show resolved Hide resolved
*
* Does not update the allowance value in case of infinite allowance.
* Revert if not enough allowance is available.
Expand Down
2 changes: 1 addition & 1 deletion contracts/token/ERC20/extensions/IERC20Permit.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ interface IERC20Permit {
* - `deadline` must be a timestamp in the future.
* - `v`, `r` and `s` must be a valid `secp256k1` signature from `owner`
* over the EIP712-formatted function arguments.
* - the signature must use ``owner``'s current nonce (see {nonces}).
* - the signature must use ``owner'``s current nonce (see {nonces}).
arr00 marked this conversation as resolved.
Show resolved Hide resolved
*
* For more information on the signature format, see the
* https://eips.ethereum.org/EIPS/eip-2612#specification[relevant EIP
Expand Down
2 changes: 1 addition & 1 deletion contracts/token/ERC20/extensions/draft-ERC20TemporaryApproval.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ abstract contract ERC20TemporaryApproval is ERC20, IERC7674 {
}

/**
* @dev Sets `value` as the temporary allowance of `spender` over the `owner` s tokens.
* @dev Sets `value` as the temporary allowance of `spender` over the `owner'`s tokens.
arr00 marked this conversation as resolved.
Show resolved Hide resolved
*
* This internal function is equivalent to `temporaryApprove`, and can be used to e.g. set automatic allowances
* for certain subsystems, etc.
Expand Down
Loading